[m3msg] Remove unnecessary ConsumeHandler interface #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhall07
changed the title
rallen090
approved these changes
Nov 10, 2021
The ConsumerHandler is redundant and unncessary. Use the MessageProcessor interface for the aggregator so it's consistent with the coordinator. This will make it easier to add some base metrics to both consumers in the future.
ryanhall07
force-pushed
the
rhall-agg-message-processor
branch
from
b968d34 to
d244307
Compare
arnikola
approved these changes
Nov 10, 2021
src/msg/consumer/handlers.go
Outdated
Comment on lines
39
to
47
| // NewMessageProcessorFn creates a new MessageProcessor scoped to a single connection. Messages are processed serially | ||
| // in a connection. | ||
| type NewMessageProcessorFn func() MessageProcessor | ||
|
|
||
| type messageHandler struct { | ||
| opts Options | ||
| mPool *messagePool | ||
| mp MessageProcessor | ||
| m metrics | ||
| // SingletonMessageProcessor uses the same MessageProcessor for all connections. | ||
| func SingletonMessageProcessor(p MessageProcessor) NewMessageProcessorFn { | ||
| return func() MessageProcessor { | ||
| return p | ||
| } |
ryanhall07
added a commit
that referenced
this pull request
Nov 19, 2021
This fixes a regression that was introduced in #3918 The shared singleton MessageProcessor was being closed when a Connection was being closed. Now a Pool interface is introduced. A MessageProcessor is fetched when a Connection is created and returned when a Connection is closed. It is up to the pool impl to decide if it should Close the MessageProcessor on each return or only when the pool is closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConsumerHandler is redundant and unncessary. Use the
MessageProcessor interface for the aggregator so it's consistent with
the coordinator.
This will make it easier to add some base metrics to both consumers in
the future.
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: