[tests] Add support for resources.ExternalResources #3811
Conversation
nbroyles
force-pushed
the
nb/external-resources
branch
2 times, most recently
from
1630bf0 to
10bd583
Compare
| return err | ||
| } | ||
|
|
||
| p.resource = nil |
There was a problem hiding this comment.
why do we need to explicitly nil this out? Also do we need synchronization on this?
There was a problem hiding this comment.
This is more of a safety thing. If the resource is nil, we know that we've cleaned up properly or haven't started a previous run. The Setup method explicitly checks for this.
Also, no synchronization should be needed here. There shouldn't be any concurrency on the same instance of a prometheus object.
This commit adds an interface for adding external (i.e. not M3) resources that can be used in integration tests. An implementation of the interface that allows users to spin up a docker-backed Prometheus is added as well. This also functions as a working example for how the interface can be implemented to support other external resources.
nbroyles
force-pushed
the
nb/external-resources
branch
from
10bd583 to
06fa74a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3811 +/- ##
========================================
- Coverage 56.8% 56.8% -0.1%
========================================
Files 552 552
Lines 63079 63079
========================================
- Hits 35876 35834 -42
- Misses 24004 24038 +34
- Partials 3199 3207 +8
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This commit adds an interface for adding external (i.e. not M3)
resources that can be used in integration tests. An
implementation of the interface that allows users to spin up
a docker-backed Prometheus is added as well. This also functions
as a working example for how the interface can be implemented to
support other external resources.
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: