[development] Promremote storage local setup #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antanukas
changed the title
Antanukas
force-pushed
the
antanas/prom-remote-write-backend-local-setup
branch
2 times, most recently
from
96ee123 to
f9aa6ee
Compare
centai [coordinator] docker integration tests for prom-remote storage cleanup, wait for leader [development] Local Docker setup for prom-remote storage working config fix test revert
Antanukas
force-pushed
the
antanas/prom-remote-write-backend-local-setup
branch
from
f9aa6ee to
026f048
Compare
Antanukas
changed the base branch from
master
to
antanas/better-error-handling
Codecov Report
@@ Coverage Diff @@
## master #3791 +/- ##
========================================
- Coverage 56.8% 56.8% -0.1%
========================================
Files 552 552
Lines 63077 63064 -13
========================================
- Hits 35888 35834 -54
- Misses 23986 24025 +39
- Partials 3203 3205 +2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Antanukas
changed the title
Antanukas
changed the title
Antanukas
changed the title
vpranckaitis
approved these changes
Oct 4, 2021
| ATTEMPTS=10 MAX_TIMEOUT=4 TIMEOUT=1 retry_with_backoff \ | ||
| 'curl -vvvsSf localhost:7201/health' | ||
|
|
||
| echo "Running aggregator pipeline" |
There was a problem hiding this comment.
nit:
Suggested change
| echo "Running aggregator pipeline" | |
| echo "Running aggregator pipeline" |
| M3AGGREGATOR_DEV_IMG=$(docker images m3aggregator:dev | fgrep -iv repository | wc -l | xargs) | ||
| M3COLLECTOR_DEV_IMG=$(docker images m3collector:dev | fgrep -iv repository | wc -l | xargs) | ||
|
|
||
| docker-compose -f docker-compose.yml up $DOCKER_ARGS etcd01 |
There was a problem hiding this comment.
nit:
Suggested change
| docker-compose -f docker-compose.yml up $DOCKER_ARGS etcd01 | |
| docker-compose -f docker-compose.yml up $DOCKER_ARGS etcd01 |
Comment on lines
63
to
71
| "consumerService": { | ||
| "serviceId": { | ||
| "name": "m3aggregator", | ||
| "environment": "default_env", | ||
| "zone": "embedded" | ||
| }, | ||
| "consumptionType": "REPLICATED", | ||
| "messageTtlNanos": "600000000000" | ||
| } |
There was a problem hiding this comment.
nit:
Suggested change
| "consumerService": { | |
| "serviceId": { | |
| "name": "m3aggregator", | |
| "environment": "default_env", | |
| "zone": "embedded" | |
| }, | |
| "consumptionType": "REPLICATED", | |
| "messageTtlNanos": "600000000000" | |
| } | |
| "consumerService": { | |
| "serviceId": { | |
| "name": "m3aggregator", | |
| "environment": "default_env", | |
| "zone": "embedded" | |
| }, | |
| "consumptionType": "REPLICATED", | |
| "messageTtlNanos": "600000000000" | |
| } |
Comment on lines
+111
to
+113
| "consumerService": { | ||
| "serviceId": { | ||
| "name": "m3coordinator", |
There was a problem hiding this comment.
Suggested change
| "consumerService": { | |
| "serviceId": { | |
| "name": "m3coordinator", | |
| "consumerService": { | |
| "serviceId": { | |
| "name": "m3coordinator", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Local dev setup to quickly test Prom Remote Write storage.
Special notes for your reviewer:
Refer to readme that describes this setup.
In order to generate some realistic metrics it's possible to scrape CAdvisor metrics from Kubernetes.
This is achieved by using
kubectl proxyand the fact that each node exposes its metrics atlocalhost:8001/api/v1/nodes/${node}/proxy/metrics/cadvisor.Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: