-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Update Graphite find calls to complete unterminated queries with all possible path values for ** #3593
Merged
robskillington
merged 10 commits into
master
from
r/fix-find-star-star-query-completions
Jul 12, 2021
Merged
[query] Update Graphite find calls to complete unterminated queries with all possible path values for ** #3593
robskillington
merged 10 commits into
master
from
r/fix-find-star-star-query-completions
Jul 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith all possible path values for **
linasm
reviewed
Jul 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have much of a context for this code, but one part of the implementation looks somewhat suspicious (see the comments inline),.
wesleyk
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously find calls did not special case
**
and such were looking for terminated and unterminated queries for fields that had any value for the first graphite path index (since matchers created for**
are special and regex against the whole timeseries ID, they cannot be treated this way and need to complete all values for all possible path indexes).This special cases the
**
case and completes tag values for all of the path indexes that could be possibly relevant to the find query.Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: