Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the namespace to the series limit error #3519

Merged
merged 3 commits into from
May 25, 2021
Merged

Conversation

ryanhall07
Copy link
Collaborator

This should help in understanding why a query exceeded the series limit.
Options are:

  1. exceeded in a single database instance. the error is returned from
    the db.
  2. exceeded within a single namespace after summing the results from
    every database.
  3. exceeded when adding the results from a namespace to the existing
    results from previous namespaces.

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


This should help in understanding why a query exceeded the series limit.
Options are:

1. exceeded in a single database instance. the error is returned from
   the db.
2. exceeded within a single namespace after summing the results from
   every database.
3. exceeded when adding the results from a namespace to the existing
   results from previous namespaces.
@ryanhall07 ryanhall07 requested review from wesleyk and arnikola May 25, 2021 19:33
@ryanhall07 ryanhall07 enabled auto-merge (squash) May 25, 2021 19:37
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #3519 (3e96cb7) into master (3e96cb7) will not change coverage.
The diff coverage is n/a.

❗ Current head 3e96cb7 differs from pull request most recent head 52cb1b4. Consider uploading reports for the commit 52cb1b4 to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3519   +/-   ##
======================================
  Coverage    55.9%   55.9%           
======================================
  Files         548     548           
  Lines       61378   61378           
======================================
  Hits        34350   34350           
  Misses      23921   23921           
  Partials     3107    3107           
Flag Coverage Δ
aggregator 57.3% <0.0%> (ø)
cluster ∅ <0.0%> (∅)
collector 54.3% <0.0%> (ø)
dbnode 60.3% <0.0%> (ø)
m3em 46.4% <0.0%> (ø)
metrics 19.8% <0.0%> (ø)
msg 74.6% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e96cb7...52cb1b4. Read the comment docs.

@ryanhall07 ryanhall07 merged commit 1a220ca into master May 25, 2021
@ryanhall07 ryanhall07 deleted the rhall-limit-error-msgs branch May 25, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants