Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[dbnode] Improve m3tsz decoding performance (#3358)" #3403

Merged

Conversation

linasm
Copy link
Collaborator

@linasm linasm commented Apr 6, 2021

This reverts commit abad1bb.

What this PR does / why we need it:
We have identified M3TSZ decoding regression that was introduced in #3358.
Suggesting to revert the change until we have a fix.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE

Does this PR require updating code package or user-facing documentation?:
NONE

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linasm linasm enabled auto-merge (squash) April 6, 2021 14:17
@linasm linasm merged commit 8cf1168 into master Apr 6, 2021
@linasm linasm deleted the linasm/revert-abad1bb2e9a4de18afcb9a29e87fa3a39a694ef4 branch April 6, 2021 14:20
vdarulis added a commit that referenced this pull request Apr 6, 2021
soundvibe added a commit that referenced this pull request Apr 7, 2021
* master:
  [dbnode] Decoder: fix handling of values requiring 64bit precision (#3406)
  Revert "Revert "[dbnode] Improve m3tsz decoding performance (#3358)" (#3403)" (#3405)
  [dbnode] TestReaderIteratorDecodingRegression (#3404)
  Revert "[dbnode] Improve m3tsz decoding performance (#3358)" (#3403)
  Update generated file (#3402)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants