Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Skip bootstrapping shards from aggregation #3394

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

linasm
Copy link
Collaborator

@linasm linasm commented Mar 29, 2021

What this PR does / why we need it:
Skip bootstrapping shards from aggregation.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE

Does this PR require updating code package or user-facing documentation?:
NONE

@linasm linasm requested a review from gediminasgu March 29, 2021 06:30
@linasm linasm enabled auto-merge (squash) March 29, 2021 06:32
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #3394 (a6a9b99) into master (9eacaa7) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3394     +/-   ##
=========================================
- Coverage    72.4%    72.4%   -0.1%     
=========================================
  Files        1098     1098             
  Lines      102382   102387      +5     
=========================================
- Hits        74178    74147     -31     
- Misses      23103    23127     +24     
- Partials     5101     5113     +12     
Flag Coverage Δ
aggregator 76.8% <ø> (-0.2%) ⬇️
cluster 84.9% <ø> (ø)
collector 84.3% <ø> (ø)
dbnode 78.9% <100.0%> (-0.1%) ⬇️
m3em 74.4% <ø> (ø)
m3ninx 73.5% <ø> (ø)
metrics 19.8% <ø> (ø)
msg 74.6% <ø> (ø)
query 67.0% <ø> (ø)
x 80.4% <ø> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eacaa7...a6a9b99. Read the comment docs.

@linasm linasm merged commit 7a950d0 into master Mar 29, 2021
@linasm linasm deleted the linasm/skip-bootstrapping-shards-from-aggregation branch March 29, 2021 08:13
soundvibe added a commit that referenced this pull request Mar 30, 2021
* master:
  Start (#3396)
  [query] Graphite fix exponentialMovingAverage seeded constant when num steps used for window size (#3395)
  [query] Fix Graphite exponentialMovingAverage to use correct EMA const and return single series per input series (#3391)
  [DOCS] Add contribution guide for documentation (#3365)
  [dbnode] Skip bootstrapping shards from aggregation (#3394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants