[query] Add Graphite sortByName natural and reverse args and generic sortBy #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3367 +/- ##
=========================================
- Coverage 72.4% 72.3% -0.1%
=========================================
Files 1099 1099
Lines 102244 102289 +45
=========================================
- Hits 74044 74041 -3
- Misses 23097 23134 +37
- Partials 5103 5114 +11
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
wesleyk
approved these changes
Mar 17, 2021
| result ts.SeriesList | ||
| err error | ||
| ) | ||
| if strings.HasPrefix(fn, "min") { |
There was a problem hiding this comment.
is there a var we can ref for min?
|
|
||
| constValues := newTestSeriesValues(ctx, 1000, []float64{1, 2, 3, 4}) | ||
| series := []*Series{ | ||
| NewSeries(ctx, "server1", time.Now(), constValues), |
There was a problem hiding this comment.
can we add coverage for "server01" style strings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds natural and reverse args to sortByName and implements the generic sortBy function.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: