Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] -- Adding clarification around etcd and M3 to etcd operational guide #3361

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

gibbscullen
Copy link
Collaborator

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #3361 (796ac5e) into master (5d23e1b) will decrease coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 796ac5e differs from pull request most recent head 334f11a. Consider uploading reports for the commit 334f11a to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3361     +/-   ##
=========================================
- Coverage    72.3%    72.3%   -0.1%     
=========================================
  Files        1099     1099             
  Lines      102229   102224      -5     
=========================================
- Hits        74007    73969     -38     
- Misses      23116    23136     +20     
- Partials     5106     5119     +13     
Flag Coverage Δ
aggregator 76.8% <ø> (-0.1%) ⬇️
cluster 84.9% <ø> (-0.1%) ⬇️
collector 84.3% <ø> (ø)
dbnode 78.9% <ø> (-0.1%) ⬇️
m3em 74.4% <ø> (ø)
m3ninx 73.5% <ø> (ø)
metrics 19.8% <ø> (ø)
msg 74.6% <ø> (ø)
query 66.9% <ø> (ø)
x 80.3% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d23e1b...334f11a. Read the comment docs.

@ChrisChinchilla
Copy link
Collaborator

Looks good @gibbscullen I will overhaul this section at a later date, but this is a nice improvement for now.

@ChrisChinchilla ChrisChinchilla merged commit 31d3bf8 into master Mar 17, 2021
@ChrisChinchilla ChrisChinchilla deleted the gibbs/etcd_doc branch March 17, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants