-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aggregator] Implement timedMetricList.FlushOffset #3292
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3292 +/- ##
=======================================
Coverage 72.3% 72.3%
=======================================
Files 1098 1098
Lines 102020 102020
=======================================
Hits 73807 73807
Misses 23115 23115
Partials 5098 5098
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and definitely surprised this was not the case before
What this PR does / why we need it:
Changes
timedMetricList
to use fixed flush offset.Special notes for your reviewer:
Dropping
fixedOffsetFlushingMetricList
interface and moving theFlushOffset()
method toflushingMetricList
(withok
flag) to avoid the error-prone type check in https://github.com/m3db/m3/pull/3292/files#diff-5a6baf266bd455b257e1a2f2ded077f3f2373a44628318748d2008d9ba59b9bcL284 which was masking the fact thattimedMetricList
was not exposing itsflushOffset
.Old code:
New code:
Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE
Does this PR require updating code package or user-facing documentation?:
NONE