[query] Fix Graphite moving functions to include series not in the query but matched by expanded range #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed data with original query fetched time window
wesleyk
approved these changes
Mar 17, 2021
| // SafeAverage returns the average of the input slice the number of NaNs in the input. | ||
| func SafeAverage(input []float64) (float64, int) { | ||
| sum, nans := SafeSum(input) | ||
| count := len(input) - nans |
There was a problem hiding this comment.
Hm good call.
There was a problem hiding this comment.
Seems like this is actually safe:
https://play.golang.org/p/MhMnzAReOd1
…original-series-mismatch
Codecov Report
@@ Coverage Diff @@
## master #3149 +/- ##
=======================================
Coverage 72.4% 72.4%
=======================================
Files 1099 1099
Lines 102294 102294
=======================================
Hits 74064 74064
Misses 23123 23123
Partials 5107 5107
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…original-series-mismatch
robskillington
deleted the
r/fix-moving-functions-with-bootstrap-and-original-series-mismatch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously the moving functions only included datapoints for series that had data in the original time window (plus the shifted values from the moving function window) but was missing datapoints for series that did not have any data in the new time window (but had shifted values from the moving function window).
Decided to also take opportunity to port
movingAverageto the new moving helper but keptexponentialMovingAveragewhere it is since it has significantly different semantics on the windowing and setup for each series.Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: