-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Fix Graphite asPercent function to handle nodes and multiple total divisor series #3142
Conversation
…total divisor series
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #3142 +/- ##
=========================================
+ Coverage 70.9% 72.6% +1.6%
=========================================
Files 1098 1099 +1
Lines 102237 103350 +1113
=========================================
+ Hits 72586 75102 +2516
+ Misses 24495 23138 -1357
+ Partials 5156 5110 -46
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
What this PR does / why we need it:
Fixes asPercent to handle nodes arg and multiple divisor series.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: