-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dbnode] Fix AggregateQuery limits #3112
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
476dbd4
[dbnode] AggregateQuery limit fix
arnikola 5a99682
Cleanup
arnikola a0ca9db
[integration test] Add label query limits integration test
wesleyk 5d2173d
Add paren
wesleyk c4ee6c6
Fixed exhaustive case, remove dead code
arnikola 522543c
Merge branch 'arnikola/fix-limits' of github.com:m3db/m3 into arnikol…
arnikola ebfaa35
Aggregate results changes
arnikola 849c92b
Add proper require exhaustive conversion + integration test for agg q…
wesleyk bd35ca9
Merge branch 'arnikola/fix-limits' of github.com:m3db/m3 into arnikol…
wesleyk cad0e06
Merge branch 'master' into arnikola/fix-limits
wesleyk 829e6b3
Avoid flakiness with high limits
wesleyk 31f001b
Limit on docs or inserts
arnikola 172100f
Fixup integration test
wesleyk 2695b90
Merge branch 'arnikola/fix-limits' of github.com:m3db/m3 into arnikol…
wesleyk 84d5a86
Add more precise assertions to label query limits integration test
wesleyk dd5ae2e
Finish test fixes and refactor
arnikola b18484e
Response + lint
arnikola ab538cd
Improve IT comments
wesleyk 505319c
Merge branch 'master' into arnikola/fix-limits
wesleyk b3fdbba
Response + lint
arnikola 4221a99
Fix integrations
arnikola 704b172
Merge branch 'arnikola/fix-limits' of github.com:m3db/m3 into arnikol…
arnikola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Response + lint
- Loading branch information
commit b3fdbba2e211e661a2294db16a07a97ef4ce30b2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so since we hit the limit, we essentially have to clean up this entire batch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, exactly