Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Query attribution #2911

Closed
wants to merge 1 commit into from
Closed

[query] Query attribution #2911

wants to merge 1 commit into from

Conversation

arnikola
Copy link
Collaborator

Resubmitting #2888 which was plagued with git + CLA issues

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


[email protected] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #2911 (af43b8c) into master (36430cc) will increase coverage by 1.4%.
The diff coverage is 69.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2911     +/-   ##
========================================
+ Coverage    71.3%   72.7%   +1.4%     
========================================
  Files        1079    1082      +3     
  Lines       98666   98796    +130     
========================================
+ Hits        70367   71861   +1494     
+ Misses      23327   21974   -1353     
+ Partials     4972    4961     -11     
Flag Coverage Δ
aggregator 76.3% <ø> (+<0.1%) ⬆️
cluster 85.0% <ø> (ø)
collector 84.3% <ø> (ø)
dbnode 78.9% <70.5%> (+3.3%) ⬆️
m3em 74.4% <ø> (ø)
m3ninx 73.1% <ø> (ø)
metrics 19.9% <ø> (ø)
msg 74.2% <ø> (+<0.1%) ⬆️
query 68.6% <54.5%> (-0.1%) ⬇️
x 79.9% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36430cc...af43b8c. Read the comment docs.

@arnikola
Copy link
Collaborator Author

the base pr, 2888, was merged

@arnikola arnikola closed this Nov 17, 2020
@arnikola arnikola deleted the arnikola/queryattr branch November 17, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants