Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Update return unfulfilled for corrupt commit log files default #2807

Merged
merged 3 commits into from
Oct 29, 2020
Merged

[dbnode] Update return unfulfilled for corrupt commit log files default #2807

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ba6f09
[dbnode] Update return unfulfilled for corrupt commit log files default
robskillington Oct 28, 2020
f3ea86d
Merge branch 'master' into r/return-unfulfilled-for-corrupt-commit-lo…
robskillington Oct 29, 2020
f023107
Fix prop test
robskillington Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dbnode/storage/bootstrap/bootstrapper/commitlog/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const (
// DefaultReturnUnfulfilledForCorruptCommitLogFiles is the default
// value for whether to return unfulfilled when encountering corrupt
// commit log files.
DefaultReturnUnfulfilledForCorruptCommitLogFiles = true
DefaultReturnUnfulfilledForCorruptCommitLogFiles = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this the default we want?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to commit description the link to the corresponding documentation:
https://github.com/m3db/m3/blob/64c6dea950ce27108841ecb82304cf8c46eea158/site/content/docs/operational_guide/availability_consistency_durability.md#ignoring-corrupt-commitlogs-on-bootstrap

)

var (
Expand Down