Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default m3msg write timeouts to 5 seconds #2698

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

ryanhall07
Copy link
Collaborator

What this PR does / why we need it:
This changes both the Producer sending new messages and the Consumer
sending ack messages.

5s is a safer default to prevent infinite blocking if the TCP connection
is not currently available for writing (i.e the buffer is full).

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:
Yes. The default write timeouts change from unbounded to 5s.

Does this PR require updating code package or user-facing documentation?:
No

This changes both the Producer sending new messages and the Consumer
sending ack messages.

5s is a safer default to prevent infinite blocking if the TCP connection
is not currently available for writing (i.e the buffer is full).
@robskillington
Copy link
Collaborator

Should we update the consumerWriterTimeout default to also be 5s?

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanhall07 ryanhall07 merged commit b524acb into master Oct 6, 2020
@ryanhall07 ryanhall07 deleted the rhall-default-timeout-5s branch October 6, 2020 21:56
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@47c219a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2698   +/-   ##
========================================
  Coverage          ?   70.0%           
========================================
  Files             ?    1091           
  Lines             ?   98151           
  Branches          ?       0           
========================================
  Hits              ?   68797           
  Misses            ?   24605           
  Partials          ?    4749           
Flag Coverage Δ
#aggregator 75.9% <ø> (?)
#cluster 85.0% <ø> (?)
#collector 62.3% <ø> (?)
#dbnode 79.4% <ø> (?)
#m3em 68.6% <ø> (?)
#m3ninx 60.9% <ø> (?)
#m3nsch 78.0% <ø> (?)
#metrics 17.2% <ø> (?)
#msg 74.2% <ø> (?)
#query 68.9% <ø> (?)
#x 55.9% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47c219a...2c72bd8. Read the comment docs.

@ryanhall07 ryanhall07 restored the rhall-default-timeout-5s branch October 15, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants