[query] Implemented movingSum, movingMax, movingMin (graphite functions) #2570
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,6 +71,53 @@ func SafeSort(input []float64) int { | |
| return nans | ||
| } | ||
|
|
||
| // SafeSum returns the sum of the input slice the number of NaNs in the input. | ||
| func SafeSum(input []float64) (float64, int) { | ||
| nans := 0 | ||
| sum := 0.0 | ||
| for _, v := range input { | ||
| if !math.IsNaN(v) { | ||
| sum += v | ||
| } else { | ||
| nans += 1 | ||
| } | ||
| } | ||
| return sum, nans | ||
| } | ||
|
|
||
| // SafeMax returns the maximum value of the input slice the number of NaNs in the input. | ||
| func SafeMax(input []float64) (float64, int) { | ||
| nans := 0 | ||
| max := -math.MaxFloat64 | ||
| for _, v := range input { | ||
| if !math.IsNaN(v) { | ||
| if v > max { | ||
| max = v | ||
| } | ||
| } else { | ||
| nans += 1 | ||
| } | ||
| } | ||
|
There was a problem hiding this comment. nit: Go prefers to limit indentation wherever possible (since it's relative to complexity of the statement). Can simplify loop by following's advice of Effective Go "In the Go libraries, you'll find that when an if statement doesn't flow into the next statement—that is, the body ends in break, continue, goto, or return—the unnecessary else is omitted.": e.g. for _, v := range input {
if math.IsNaN(v) {
nans++
continue
}
if v > max {
max = v
}
} |
||
| return max, nans | ||
| } | ||
|
|
||
| // SafeMin returns the minimum value of the input slice the number of NaNs in the input. | ||
| func SafeMin(input []float64) (float64, int) { | ||
| nans := 0 | ||
| min := math.MaxFloat64 | ||
| for _, v := range input { | ||
| if !math.IsNaN(v) { | ||
| if v < min { | ||
|
There was a problem hiding this comment. nit: Go prefers to limit indentation wherever possible (since it's relative to complexity of the statement). Can simplify loop by following's advice of Effective Go "In the Go libraries, you'll find that when an if statement doesn't flow into the next statement—that is, the body ends in break, continue, goto, or return—the unnecessary else is omitted.": e.g. for _, v := range input {
if math.IsNaN(v) {
nans++
continue
}
if v < min {
min = v
}
} |
||
| min = v | ||
| } | ||
| } else { | ||
| nans += 1 | ||
| } | ||
| } | ||
| return min, nans | ||
| } | ||
|
|
||
|
|
||
| // GetPercentile computes the percentile cut off for an array of floats | ||
| func GetPercentile(input []float64, percentile float64, interpolate bool) float64 { | ||
| nans := SafeSort(input) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation of inner of "if" contents is missing - needs further indenting. Looks like this file is not saved with "gofmt". Suprised linter hasn't caught this... Can you run "gofmt" on all these files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use a standard Go editor, it should run it for you on save. (i.e. vimgo, vscode w/ Go extensions, Go Land, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I do edit with GoLand, which always catches stuff like this. The only reason this mis-indentation was included was because I manually did it on Github. A few days ago, I tried to make a trivial change, just so I could force the CI to re-run.