-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[large-tiles] Integrate cross block series reader #2543
Conversation
…ock-series-reader
…-cross-block-series-reader
…-cross-block-series-reader
…-cross-block-series-reader
…ock-series-reader
Codecov Report
@@ Coverage Diff @@
## large-tiles-aggregation #2543 +/- ##
=========================================================
Coverage ? 71.7%
=========================================================
Files ? 1083
Lines ? 95799
Branches ? 0
=========================================================
Hits ? 68696
Misses ? 22486
Partials ? 4617
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## large-tiles-aggregation #2543 +/- ##
=======================================================
Coverage 48.8% 48.8%
=======================================================
Files 948 948
Lines 84952 84952
=======================================================
Hits 41458 41458
Misses 40076 40076
Partials 3418 3418
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
if !singleUnit { | ||
// TODO: what happens if unit has changed mid-tile? | ||
// Write early and then do the remaining values separately? | ||
unit = frame.Units().Values()[downsampledValue.FrameIndex] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will panic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging @arnikola (not sure if you were subscribed to this PR notifications; also, not sure what is the original branch for this piece of code). I believe @gediminasgu has fixed it in his downstream branch, but still IMHO we should do a fix at the source so that we don't run into this again.
if !singleAnnotation { | ||
// TODO: what happens if annotation has changed mid-tile? | ||
// Write early and then do the remaining values separately? | ||
annotation = frame.Annotations().Values()[downsampledValue.FrameIndex] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will panic too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arnikola (same as above).
Closing as outdated. |
What this PR does / why we need it:
Integrates CrossBlockReader into AggregateTiles process to allow aggregating series from multiple source blocks.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE
Does this PR require updating code package or user-facing documentation?:
NONE