[query_data_files] Utility for querying and decoding results into Arrow buffers #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnikola
changed the title
linasm
reviewed
Jul 20, 2020
linasm
reviewed
Jul 20, 2020
arnikola
changed the title
linasm
reviewed
Jul 22, 2020
linasm
requested changes
Jul 24, 2020
There was a problem hiding this comment.
I believe series_block_iterator.go needs its own set of unit tests. That panic on EOF (#2451 (comment)) was caught by tests of a higher level component, but that is too indirect and too incomprehensive.
Yeah need to add the test for this, but that bug was fixed in the pr for the integration i believe |
|
Not going this path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
POC on decoding directly to Apache Arrow buffers