Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP [query] Add debug params to Prometheus Remote Read to return raw query data for PromQL queries as input as well as JSON formatted results #2267

Conversation

robskillington
Copy link
Collaborator

@robskillington robskillington commented Apr 15, 2020

What this PR does / why we need it:

TODO:

  • Set merge base as master once [query] Refactor query code, add warnings to prom output #2265 merged
  • Cleanup, currently quite messy
  • Add test or two
  • Revert unnecessary changes
  • Update comparator.Series to not use map for tags so that can get deterministic in order results (and flatten to determine duplicates using jq and sort -u together)
  • Add very short note to documentation

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@arnikola
Copy link
Collaborator

Follow up PR: #2278

@arnikola arnikola closed this Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants