Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Temporarily disable kubeval validation #2241

Merged
merged 5 commits into from
Apr 2, 2020

Conversation

schallert
Copy link
Collaborator

Kubeval depends on hashicorp/go-multierror, which now depends on
go1.13 error methods.

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


Kubeval depends on `hashicorp/go-multierror`, which now depends on
go1.13 error methods.
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #2241 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2241     +/-   ##
========================================
- Coverage    72.6%   72.4%   -0.3%     
========================================
  Files        1024    1024             
  Lines       89710   89129    -581     
========================================
- Hits        65174   64533    -641     
- Misses      20162   20248     +86     
+ Partials     4374    4348     -26     
Flag Coverage Δ
#aggregator 82.0% <ø> (-0.1%) ⬇️
#cluster 85.2% <ø> (ø)
#collector 82.8% <ø> (ø)
#dbnode 79.0% <ø> (-0.3%) ⬇️
#m3em 74.1% <ø> (-0.3%) ⬇️
#m3ninx 74.4% <ø> (ø)
#m3nsch 51.1% <ø> (ø)
#metrics 17.5% <ø> (ø)
#msg 74.9% <ø> (ø)
#query 68.8% <ø> (-0.7%) ⬇️
#x 83.2% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e794f2...4ae4313. Read the comment docs.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schallert schallert marked this pull request as ready for review April 2, 2020 01:19
@schallert
Copy link
Collaborator Author

Ref #2220

@schallert schallert merged commit de15419 into master Apr 2, 2020
@schallert schallert deleted the schallert/temp_remove_kubeval branch April 2, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants