Add an in memory implementation of cluster/client.Client #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmains12
force-pushed
the
amains/cluster/memcluster
branch
from
183042b to
e586953
Compare
Codecov Report
@@ Coverage Diff @@
## master #2219 +/- ##
========================================
- Coverage 72.4% 66.2% -6.2%
========================================
Files 1022 1023 +1
Lines 88870 88918 +48
========================================
- Hits 64392 58919 -5473
- Misses 20160 25553 +5393
- Partials 4318 4446 +128
Continue to review full report at Codecov.
|
vdarulis
approved these changes
Mar 19, 2020
|
Thanks for this @andrewmains12 and yes the current client is very tightly coupled to etcd =[ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds a small testing utility to back a
cluster/client.Clientwith an in-memory kv.Store. We have thecluster/kv/memimplementation of kv.Store, but there's currently no way to back acluster/client.Clientwith it. Construction of the kv.Store is tightly coupled with etcd in the current class; having a separate class seemed like a reasonable way to do this given the current code, but we could consider a more dependency injection style for that--let me know if you want to hash that out.Special notes for your reviewer:
Does this PR require updating code package or user-facing documentation?: