[dbnode] Use invariant error for flush errors to fail CI with flush errors in integration tests #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robskillington
changed the title
arnikola
approved these changes
Mar 25, 2020
|
Looks like this is causing some integration tests to fail; should the fix for those go into this PR or separate? |
|
@arnikola I'm looking at the errors. |
* Wait for fs processes to finish before closing db. * Only read data from disk when flushing index segments.
Codecov Report
@@ Coverage Diff @@
## master #2217 +/- ##
========================================
- Coverage 71.9% 71.1% -0.8%
========================================
Files 1024 1021 -3
Lines 89726 88855 -871
========================================
- Hits 64581 63254 -1327
- Misses 20827 21258 +431
- Partials 4318 4343 +25
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This catches any flush errors that are introduced and occur during integration tests, since invariant errors will panic the CI tests.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: