Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for BootstrappedAndDurable #2210

Merged
merged 2 commits into from
Mar 15, 2020
Merged

Conversation

justinjc
Copy link
Collaborator

What this PR does / why we need it:

BootstrappedAndDurable is what is reported as "bootstrapped" by /health endpoint. Adding this metric gives us visibility in this database status without hitting the endpoint for that information.

Special notes for your reviewer: N/A

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@justinjc justinjc requested a review from andrewmains12 March 13, 2020 19:23
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #2210 into master will decrease coverage by 5.5%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2210     +/-   ##
========================================
- Coverage    72.2%   66.7%   -5.6%     
========================================
  Files        1022    1017      -5     
  Lines       89178   88488    -690     
========================================
- Hits        64440   59064   -5376     
- Misses      20447   25449   +5002     
+ Partials     4291    3975    -316
Flag Coverage Δ
#aggregator 82% <ø> (+0.7%) ⬆️
#cluster 85.3% <ø> (-0.1%) ⬇️
#collector 82.8% <ø> (ø) ⬆️
#dbnode 79% <100%> (-0.1%) ⬇️
#m3em 73.4% <ø> (-1%) ⬇️
#m3ninx 69.1% <ø> (-3.3%) ⬇️
#m3nsch 17.9% <ø> (-33.2%) ⬇️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 44.9% <ø> (-23.8%) ⬇️
#x 76.8% <ø> (-6.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a3f8c...1fb9892. Read the comment docs.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinjc justinjc merged commit 66f5bd7 into master Mar 15, 2020
@justinjc justinjc deleted the juchan/durable-metric branch March 15, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants