[aggregator] Take last value by value timestamp not arrival time #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schallert
approved these changes
Mar 9, 2020
arnikola
reviewed
Mar 9, 2020
arnikola
reviewed
Mar 9, 2020
arnikola
reviewed
Mar 9, 2020
|
Looks like there's a few build breaks, got a few nits, but generally lgtm |
Codecov Report
@@ Coverage Diff @@
## master #2199 +/- ##
========================================
+ Coverage 71.4% 72.2% +0.7%
========================================
Files 1018 1022 +4
Lines 88519 88724 +205
========================================
+ Hits 63282 64086 +804
+ Misses 20976 20346 -630
- Partials 4261 4292 +31
Continue to review full report at Codecov.
|
arnikola
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We've noticed that at times a bunch of values for the same gauge can arrive at the same time to the aggregator with a varying set of timestamps, gauge last value aggregation should take the last value by timestamp not by arrival time to account for this.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: