-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add set placement endpoint docs #2183
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2183 +/- ##
========================================
+ Coverage 72.2% 72.3% +0.1%
========================================
Files 1017 1016 -1
Lines 88265 88056 -209
========================================
- Hits 63739 63693 -46
+ Misses 20239 20086 -153
+ Partials 4287 4277 -10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2183 +/- ##
========================================
- Coverage 72.3% 71.8% -0.5%
========================================
Files 1016 1016
Lines 88056 88056
========================================
- Hits 63701 63309 -392
- Misses 20082 20504 +422
+ Partials 4273 4243 -30
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than minor bit about removing mention of “seed node” and just mentioning “nodes”
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: