[integrations] Add a datasource variable and reuse it in all the panels of the aggregator dashboard #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls of the aggregator dashboard
|
|
arnikola
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
When importing the M3 aggregator dashboard to use in Grafana, all the panels were showing an empty query and some sample visualizations. AFAIK the missing
datasourceproperty in the JSON caused it to revert back to the "sample data". Since all the metrics were missing anyhow it was not easy to make it work.This PR introduces a
$datasourcevariable as the first variable that lists all the available Prometheus datasources. This variable is then used/added to all the panels in the dashboard which should make it easier to customize in the future since the panel will no be fixed to a particular name for the datasource.Tested using the latest Grafana stable release v6.6.2.
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: