Add regression test for and fix deadlock. #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbdu
force-pushed
the
bdu/leasemgr-deadlock
branch
from
c82281b to
67b0c6b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2169 +/- ##
======================================
Coverage 72.2% 72.2%
======================================
Files 1016 1016
Lines 87985 87985
======================================
Hits 63597 63597
Misses 20122 20122
Partials 4266 4266
Continue to review full report at Codecov.
|
arnikola
reviewed
Feb 26, 2020
| } | ||
| wg.Add(2) | ||
| go func() { | ||
| wg.Done() |
There was a problem hiding this comment.
Should these be Done after the OpenLease call?
There was a problem hiding this comment.
We just want to wait for the goroutine to bootstrap. The calls are done in a loop till the server is called. They were the original source of the deadlock.
arnikola
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #2155 .
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: