Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make number of series a property of prop test #2130

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Conversation

justinjc
Copy link
Collaborator

Follow up from PR #2128 (comment)

@justinjc justinjc requested a review from prateek January 31, 2020 00:25
Copy link
Collaborator

@prateek prateek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ a nit

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #2130 into master will increase coverage by 18.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2130      +/-   ##
==========================================
+ Coverage    51.1%    69.4%   +18.3%     
==========================================
  Files         773     1012     +239     
  Lines       62300   130262   +67962     
==========================================
+ Hits        31844    90443   +58599     
- Misses      28273    33734    +5461     
- Partials     2183     6085    +3902
Flag Coverage Δ
#aggregator 80.8% <ø> (-19.2%) ⬇️
#cluster 68.1% <ø> (-31.9%) ⬇️
#collector 64.8% <ø> (+32.1%) ⬆️
#dbnode 77.9% <ø> (+3.1%) ⬆️
#m3em 72.5% <ø> (-27.5%) ⬇️
#m3ninx 69.8% <ø> (-30.2%) ⬇️
#m3nsch 59.6% <ø> (-40.4%) ⬇️
#metrics 17.6% <ø> (-82.4%) ⬇️
#msg 74.7% <ø> (-25.3%) ⬇️
#query 49.9% <ø> (-50.1%) ⬇️
#x 82.5% <ø> (-17.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af17524...caf82e3. Read the comment docs.

@justinjc justinjc merged commit 8fe0776 into master Jan 31, 2020
@justinjc justinjc deleted the juchan/test-id-param branch January 31, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants