-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tools] CLI tool to simplify some tasks, and eliminate the curl commands from the docs #2097
Conversation
Awesome idea 👏 |
Codecov Report
@@ Coverage Diff @@
## master #2097 +/- ##
========================================
- Coverage 72.4% 72% -0.4%
========================================
Files 1007 1003 -4
Lines 86460 86415 -45
========================================
- Hits 62614 62261 -353
- Misses 19676 19955 +279
- Partials 4170 4199 +29
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
I'm not aware of a ticket asking for this, but I've seen in the chat's an interest in tooling that will allow the docs to look cleaner by getting rid of the curl commands.
I'm working with m3db a bit and found I wanted some of this functionality as a tool, so I made it. I thought it would be a good fit here.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: