Instrument async replication worker pool utilization #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/dbnode/client/config.go
Outdated
| @@ -312,8 +312,10 @@ func (c Configuration) NewAdminClient( | |||
| size = *c.AsyncWriteWorkerPoolSize | |||
| } | |||
|
|
|||
| workerPoolInstrumentOpts := iopts.SetMetricsScope(writeRequestScope) | |||
There was a problem hiding this comment.
super nit: should this maybe be a sub-scope of writeRequestScope? maybe .Subscope("workerpool" or something
richardartoul
approved these changes
Dec 5, 2019
simonrobb
force-pushed
the
srobb/instrument-replication-worker-pool
branch
from
1b52061 to
1644a68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PooledWorkerPoolis already instrumented so this PR just passes in instrument options during instantiation.