Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Cleaning up nits from #2049 and #2055 #2056

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Conversation

arnikola
Copy link
Collaborator

@arnikola arnikola commented Dec 3, 2019

Cleans up nits from #2049 and #2055 which we didn't manage to address in those PRs

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #2056 into master will increase coverage by 3%.
The diff coverage is 73.9%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2056     +/-   ##
========================================
+ Coverage    68.1%   71.2%     +3%     
========================================
  Files        1011     999     -12     
  Lines       87290   86544    -746     
========================================
+ Hits        59498   61654   +2156     
+ Misses      23368   20640   -2728     
+ Partials     4424    4250    -174
Flag Coverage Δ
#aggregator 57.4% <ø> (-23%) ⬇️
#cluster 68.1% <ø> (+8.5%) ⬆️
#collector 65.4% <ø> (+45.5%) ⬆️
#dbnode 75.1% <ø> (+4%) ⬆️
#m3em 23.3% <ø> (-40.8%) ⬇️
#m3ninx 41.6% <ø> (-32.4%) ⬇️
#m3nsch 2.5% <ø> (-48.7%) ⬇️
#metrics 18.4% <ø> (-15.7%) ⬇️
#msg 20.1% <ø> (-54.7%) ⬇️
#query 64% <73.9%> (-1.4%) ⬇️
#x 60.6% <ø> (-16.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cbe5a8...33bb32c. Read the comment docs.

@arnikola arnikola force-pushed the arnikola/address-nits branch from d11df61 to 33bb32c Compare December 10, 2019 21:18
@robskillington robskillington changed the title [query] cleaning up nits from #2049 and #2055 [query] Cleaning up nits from #2049 and #2055 Dec 10, 2019
Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnikola arnikola merged commit 3cb0b13 into master Dec 10, 2019
@justinjc justinjc deleted the arnikola/address-nits branch May 14, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants