[dbnode] Fix bootstrapping data for an unowned shard with commit log #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnikola
reviewed
Nov 27, 2019
| @@ -476,6 +478,13 @@ func (s *commitLogSource) Read( | |||
| datapointsSkippedNotBootstrappingNamespace++ | |||
| continue | |||
| } | |||
| // If not bootstrapping shard for this series then also skip. | |||
There was a problem hiding this comment.
nit for future work: maybe good to have a short explanation here describing how this state can occur
There was a problem hiding this comment.
Sounds good, will do.
arnikola
reviewed
Nov 27, 2019
| fmt.Errorf("result missing for namespace: %v", nsID.String()) | ||
|
|
||
| var result NamespaceResult | ||
| if err == nil { |
There was a problem hiding this comment.
nit for future: this may read cleaner if you do the error logging seperately?
arnikola
approved these changes
Nov 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #2052 +/- ##
==========================================
- Coverage 71.2% 67% -4.2%
==========================================
Files 1011 1011
Lines 87030 110267 +23237
==========================================
+ Hits 61980 73981 +12001
- Misses 20867 31714 +10847
- Partials 4183 4572 +389
Continue to review full report at Codecov.
|
robskillington
deleted the
r/fix-bootstrapping-data-for-unowned-shard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes issue #2051 on master with the latest bootstrapping changes, the commit log bootstrapper was attempting to bootstrap data from shards it no longer owned.
Followup change with an integration test to catch this case will follow.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: