Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make expand work by default #2033

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Conversation

andrewmains12
Copy link
Contributor

What this PR does / why we need it:

My previous config PR didn't have the default behavior I expected it to--go.uber.org/config only expands env vars if you pass it the option.

I made x/config pass os.LookupEnv as an option to the config library by default.
Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

${VAR_NAME} strings will now actually be expanded.

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #2033 into master will decrease coverage by 5.8%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2033     +/-   ##
========================================
- Coverage    72.5%   66.7%   -5.9%     
========================================
  Files         999     995      -4     
  Lines       85840   86121    +281     
========================================
- Hits        62315   57522   -4793     
- Misses      19295   24407   +5112     
+ Partials     4230    4192     -38
Flag Coverage Δ
#aggregator 82.5% <ø> (+14.2%) ⬆️
#cluster 65.4% <ø> (+1.7%) ⬆️
#collector 67.1% <ø> (+27.9%) ⬆️
#dbnode 70.9% <ø> (+10%) ⬆️
#m3em 46.8% <ø> (+14%) ⬆️
#m3ninx 74.2% <ø> (+50.9%) ⬆️
#m3nsch 51.1% <ø> (+5%) ⬆️
#metrics 17.7% <ø> (-5.4%) ⬇️
#msg 57.8% <100%> (-15.3%) ⬇️
#query 47.6% <ø> (-25%) ⬇️
#x 55.3% <100%> (+37.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee24d35...cfca092. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #2033 into master will decrease coverage by 5.8%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2033     +/-   ##
========================================
- Coverage    72.5%   66.7%   -5.9%     
========================================
  Files         999     995      -4     
  Lines       85840   86121    +281     
========================================
- Hits        62315   57522   -4793     
- Misses      19295   24407   +5112     
+ Partials     4230    4192     -38
Flag Coverage Δ
#aggregator 82.5% <ø> (+14.2%) ⬆️
#cluster 65.4% <ø> (+1.7%) ⬆️
#collector 67.1% <ø> (+27.9%) ⬆️
#dbnode 70.9% <ø> (+10%) ⬆️
#m3em 46.8% <ø> (+14%) ⬆️
#m3ninx 74.2% <ø> (+50.9%) ⬆️
#m3nsch 51.1% <ø> (+5%) ⬆️
#metrics 17.7% <ø> (-5.4%) ⬇️
#msg 57.8% <100%> (-15.3%) ⬇️
#query 47.6% <ø> (-25%) ⬇️
#x 55.3% <100%> (+37.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee24d35...cfca092. Read the comment docs.

@andrewmains12 andrewmains12 merged commit 5d49308 into master Nov 1, 2019
@justinjc justinjc deleted the amains/config/fix_default_expand branch November 27, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants