Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in flush.go that would cause persist manager to get stuck in idle state #2007

Merged
merged 3 commits into from
Oct 17, 2019

Conversation

richardartoul
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #2007 into master will increase coverage by 2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2007     +/-   ##
=========================================
+ Coverage    61.5%    63.6%     +2%     
=========================================
  Files        1118     1124      +6     
  Lines      106427   106753    +326     
=========================================
+ Hits        65477    67910   +2433     
+ Misses      36583    34492   -2091     
+ Partials     4367     4351     -16
Flag Coverage Δ
#aggregator 79.7% <ø> (ø) ⬆️
#cluster 56.3% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 65% <0%> (+3.3%) ⬆️
#m3em 59.6% <ø> (+13.1%) ⬆️
#m3ninx 61.1% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.7% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 68.6% <ø> (ø) ⬆️
#x 75% <ø> (+6.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351e12d...e2e24b9. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #2007 into master will increase coverage by 2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2007     +/-   ##
=========================================
+ Coverage    61.5%    63.6%     +2%     
=========================================
  Files        1118     1124      +6     
  Lines      106427   106753    +326     
=========================================
+ Hits        65477    67910   +2433     
+ Misses      36583    34492   -2091     
+ Partials     4367     4351     -16
Flag Coverage Δ
#aggregator 79.7% <ø> (ø) ⬆️
#cluster 56.3% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 65% <0%> (+3.3%) ⬆️
#m3em 59.6% <ø> (+13.1%) ⬆️
#m3ninx 61.1% <ø> (-0.1%) ⬇️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.7% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 68.6% <ø> (ø) ⬆️
#x 75% <ø> (+6.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351e12d...5dd6456. Read the comment docs.

Copy link
Collaborator

@justinjc justinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@richardartoul richardartoul merged commit 1eb7e3f into master Oct 17, 2019
@richardartoul richardartoul deleted the ra/fix-flush-persist branch October 17, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants