Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBNode] - Add support for batching fetches across namespaces #1987

Merged
merged 11 commits into from
Oct 8, 2019

Conversation

richardartoul
Copy link
Contributor

No description provided.

@richardartoul richardartoul changed the title [WIP] - Add support for batching fetches across namespaces [DBNode] - Add support for batching fetches across namespaces Oct 7, 2019
@richardartoul richardartoul requested a review from justinjc October 7, 2019 20:00
@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #1987 into master will increase coverage by 0.1%.
The diff coverage is 92.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1987     +/-   ##
=========================================
+ Coverage    63.3%    63.5%   +0.1%     
=========================================
  Files        1111     1121     +10     
  Lines      105465   106163    +698     
=========================================
+ Hits        66841    67454    +613     
- Misses      34323    34392     +69     
- Partials     4301     4317     +16
Flag Coverage Δ
#aggregator 79.7% <ø> (-0.1%) ⬇️
#cluster 56.4% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 65% <92.9%> (+0.1%) ⬆️
#m3em 59.6% <ø> (ø) ⬆️
#m3ninx 61.1% <ø> (+2.4%) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.7% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 68.2% <ø> (ø) ⬆️
#x 75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c0d4e...fdfe4c8. Read the comment docs.

Copy link
Collaborator

@justinjc justinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardartoul richardartoul merged commit 8d81062 into master Oct 8, 2019
@richardartoul richardartoul deleted the ra/batch-fetch branch October 8, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants