Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Remove invariant possibility when reading from enqueue channel #1980

Merged
merged 5 commits into from
Oct 7, 2019

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #1980 into master will increase coverage by <.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1980     +/-   ##
=========================================
+ Coverage    63.4%    63.4%   +<.1%     
=========================================
  Files        1119     1119             
  Lines      106004   106004             
=========================================
+ Hits        67278    67297     +19     
+ Misses      34414    34400     -14     
+ Partials     4312     4307      -5
Flag Coverage Δ
#aggregator 79.7% <0%> (-0.1%) ⬇️
#cluster 56.3% <0%> (ø) ⬆️
#collector 63.7% <0%> (ø) ⬆️
#dbnode 64.9% <0%> (ø) ⬆️
#m3em 59.6% <0%> (ø) ⬆️
#m3ninx 61.1% <0%> (ø) ⬆️
#m3nsch 51.1% <0%> (ø) ⬆️
#metrics 17.7% <0%> (ø) ⬆️
#msg 74.7% <0%> (ø) ⬆️
#query 68.2% <0%> (ø) ⬆️
#x 75% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dd55f3...73539de. Read the comment docs.

Copy link
Contributor

@richardartoul richardartoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardartoul richardartoul merged commit a6c0d4e into master Oct 7, 2019
@richardartoul richardartoul deleted the r/fix-possible-invariant branch October 7, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants