Optimize fetch pathway to avoid decoding more data than required to satisfy consistency #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinjc
reviewed
Sep 26, 2019
richardartoul
changed the title
richardartoul
force-pushed
the
ra/optimize-fetch
branch
from
6b9b03a to
ff3aed3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1966 +/- ##
=========================================
Coverage ? 63.5%
=========================================
Files ? 1121
Lines ? 106180
Branches ? 0
=========================================
Hits ? 67466
Misses ? 34403
Partials ? 4311
Continue to review full report at Codecov.
|
justinjc
reviewed
Oct 11, 2019
| case ReadConsistencyLevelNone: | ||
| return 0 | ||
| } | ||
| panic(fmt.Errorf("unrecognized consistency level: %s", level.String())) |
There was a problem hiding this comment.
Why panic instead of returning an error here? Seems unidiomatic especially for just a simple helper function. If you really want to panic in the client session, it should catch the error thrown here and panic at the client session code.
There was a problem hiding this comment.
Alllright, seems like all other functions here panic instead of returning an error...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.