[query] topic api: support DELETE on /topic #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benraskin92
reviewed
Sep 5, 2019
| @@ -94,21 +87,3 @@ func TestTopicGetHandler(t *testing.T) { | |||
| resp = w.Result() | |||
| require.Equal(t, http.StatusNotFound, resp.StatusCode) | |||
| } | |||
|
|
|||
| func validateEqualTopicProto(t *testing.T, this, other topicpb.Topic) { | |||
There was a problem hiding this comment.
Meant to delete these tests?
There was a problem hiding this comment.
Yeah moved to common_test.go
benraskin92
reviewed
Sep 5, 2019
| @@ -0,0 +1,56 @@ | |||
| // Copyright (c) 2018 Uber Technologies, Inc. | |||
Users may need to delete m3msg topics.
schallert
force-pushed
the
schallert/topic_delete_api
branch
from
adb5630 to
d7e5792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may need to delete m3msg topics.
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: