-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBNode] - Add support for passive replication between M3DB Clusters #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardartoul
changed the title
Add support for passive replication between M3DB Clusters
[DBNode] - Add support for passive replication between M3DB Clusters
Aug 13, 2019
richardartoul
force-pushed
the
ra/cross-region-config
branch
from
August 13, 2019 16:34
0f3264f
to
1ce47ef
Compare
justinjc
reviewed
Aug 13, 2019
justinjc
approved these changes
Aug 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This feature leverages the existing background repairs feature to add support for configuring M3DB clusters to passively replicate data from each other. It works by refactoring the background repairs feature to support multiple M3DB clients. For background repairs a client for the local cluster is used, for cross-region replication a client for the cluster to replicate from is used, and if both feature are enabled then both clients are used.
Fixes #
Lack of support for replication between M3DB clusters.
Special notes for your reviewer:
N.A
Does this PR introduce a user-facing and/or backwards incompatible change?:
N.A
Does this PR require updating code package or user-facing documentation?:
N.A