Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBNode] - Add support for passive replication between M3DB Clusters #1874

Merged
merged 21 commits into from
Aug 14, 2019

Conversation

richardartoul
Copy link
Contributor

@richardartoul richardartoul commented Aug 13, 2019

What this PR does / why we need it:
This feature leverages the existing background repairs feature to add support for configuring M3DB clusters to passively replicate data from each other. It works by refactoring the background repairs feature to support multiple M3DB clients. For background repairs a client for the local cluster is used, for cross-region replication a client for the cluster to replicate from is used, and if both feature are enabled then both clients are used.

Fixes #
Lack of support for replication between M3DB clusters.

Special notes for your reviewer:
N.A

Does this PR introduce a user-facing and/or backwards incompatible change?:
N.A
Does this PR require updating code package or user-facing documentation?:
N.A

@richardartoul richardartoul changed the title Add support for passive replication between M3DB Clusters [DBNode] - Add support for passive replication between M3DB Clusters Aug 13, 2019
@richardartoul richardartoul force-pushed the ra/cross-region-config branch from 0f3264f to 1ce47ef Compare August 13, 2019 16:34
@richardartoul richardartoul requested a review from justinjc August 13, 2019 16:35
src/cmd/services/m3dbnode/config/config.go Outdated Show resolved Hide resolved
src/dbnode/storage/repair/options.go Outdated Show resolved Hide resolved
src/dbnode/server/server.go Outdated Show resolved Hide resolved
src/dbnode/storage/repair.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@justinjc justinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardartoul richardartoul merged commit 4a99d83 into master Aug 14, 2019
@richardartoul richardartoul deleted the ra/cross-region-config branch August 14, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants