Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Add ability to configure reflection for query GRPC server #1856

Merged
merged 8 commits into from
Sep 11, 2019

Conversation

robskillington
Copy link
Collaborator

@robskillington robskillington commented Aug 7, 2019

What this PR does / why we need it:

Useful for debugging whether the query GRPC service can be reached or not, via tools like grpcurl, etc.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

Copy link
Collaborator

@martin-mao martin-mao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robskillington robskillington merged commit bbdac9e into master Sep 11, 2019
@robskillington robskillington deleted the r/query-grpc-reflection-config branch September 11, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants