Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Log config file in query/coordinator #1803

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

benraskin92
Copy link
Collaborator

What this PR does / why we need it:

Fixes #1801

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

Copy link
Collaborator

@arnikola arnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -130,6 +130,7 @@ func Run(runOpts RunOptions) {
fmt.Fprintf(os.Stderr, "unable to load %s: %v", runOpts.ConfigFile, err)
os.Exit(1)
}
fmt.Fprintf(os.Stdout, "using %s config file: %v", serviceName, runOpts.ConfigFile)
Copy link
Collaborator

@arnikola arnikola Jul 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meganit; newline, take it or leave it

@benraskin92 benraskin92 merged commit a165343 into master Jul 15, 2019
@benraskin92 benraskin92 deleted the braskin/log_config_file branch July 15, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log if using default config in coordinator
2 participants