Add aggregation specific errors #1731
Conversation
There was a problem hiding this comment.
@robskillington Can you feature flag this behind some kind of verbosity flag thats disabled by default (but enabled in m3coordinator)? This looks like its 5 string allocations per rejected data point which could definitely cause issues for us with the distributed aggregation tier.
I talked to @cw9 and @vdarulis and they said we actually get a lot of these errors since we're forwarding traffic from the shunts
|
@richardartoul sure thing not opposed to that, put it behind a flag for now and added config that allows adjusting the values if required too. |
Codecov Report
@@ Coverage Diff @@
## master #1731 +/- ##
========================================
+ Coverage 71.8% 71.9% +<.1%
========================================
Files 981 981
Lines 81875 81904 +29
========================================
+ Hits 58867 58904 +37
+ Misses 19140 19131 -9
- Partials 3868 3869 +1
Continue to review full report at Codecov.
|
What this PR does / why we need it:
Returns specific errors for metrics that are being aggregated that arrive too late or too early.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: