[ci] build + release with go1.12 (again) #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1674 +/- ##
========================================
+ Coverage 71.8% 71.9% +<.1%
========================================
Files 968 974 +6
Lines 81169 81215 +46
========================================
+ Hits 58345 58403 +58
+ Misses 18990 18978 -12
Partials 3834 3834
Continue to review full report at Codecov.
|
bai
reviewed
May 29, 2019
| @@ -46,7 +46,7 @@ steps: | |||
| command: make clean install-vendor docker-integration-test | |||
| env: | |||
| CGO_ENABLED: 0 | |||
| GIMME_GO_VERSION: 1.10.x | |||
| GIMME_GO_VERSION: 1.12.x | |||
There was a problem hiding this comment.
Curious: is there any reason for keeping make clean install-vendor docs-test on 1.10?
bai
reviewed
May 29, 2019
docker-compose.yml
Outdated
| @@ -1,5 +1,5 @@ | |||
| app: | |||
| image: golang:1.10.4-stretch | |||
| image: golang:1.12.1-stretch | |||
There was a problem hiding this comment.
Nitpick: this will run on 1.12.1, while Buildkite (as well as Dockerfile below) will give you 1.12.5 once it expands 1.12.x.
schallert
force-pushed
the
schallert/go_1_12_again
branch
from
b185185 to
87c95da
Compare
|
Thanks for the heads up @bai! |
schallert
force-pushed
the
schallert/go_1_12_again
branch
from
87c95da to
36ab7df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after ongoing docker fixes.
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: