Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PANIC_ON_INVARIANT_VIOLATED=true for integration tests #1622

Merged

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

This re-enables using PANIC_ON_INVARIANT_VIOLATED=true for integration tests, since the root of the issue that led us to disabling it is fixed with PR #1531.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #1622 into master will increase coverage by 9.4%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1622     +/-   ##
========================================
+ Coverage    62.5%   71.9%   +9.4%     
========================================
  Files         952     954      +2     
  Lines       79134   79171     +37     
========================================
+ Hits        49518   56996   +7478     
+ Misses      25897   18453   -7444     
- Partials     3719    3722      +3
Flag Coverage Δ
#aggregator 82.3% <ø> (+8.1%) ⬆️
#cluster 85.7% <ø> (+15.7%) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 79.9% <0%> (+6.1%) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 73.9% <ø> (+8.5%) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.7% <ø> (ø) ⬆️
#query 67.1% <ø> (+21.9%) ⬆️
#x 87.2% <ø> (+8.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582dc07...a4a8135. Read the comment docs.

@robskillington robskillington merged commit 6fefee8 into master May 9, 2019
@robskillington robskillington deleted the r/re-enable-panic-on-invariant-integration-tests branch May 9, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants