Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Ignore name tags for matching binary functions #1604

Merged
merged 2 commits into from
May 6, 2019

Conversation

arnikola
Copy link
Collaborator

@arnikola arnikola commented May 6, 2019

What this PR does / why we need it:
Fixes #1520

Special notes for your reviewer:
Fixes an issue in binary functions; previously there was a requirement that series name tags matched to match series from left and right; this drops name tags from binary functions.

NB: this also drops the name tag from appearing in the output series for binary operations with a scalar argument; this is intentional to mirror the same behaviour as Prometheus

Does this PR introduce a user-facing and/or backwards incompatible change?:

Fixes an issue where binary functions would not match series correctly.

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #1604 into master will decrease coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1604     +/-   ##
========================================
- Coverage    71.9%   71.9%   -0.1%     
========================================
  Files         953     953             
  Lines       78919   78929     +10     
========================================
- Hits        56813   56803     -10     
- Misses      18400   18414     +14     
- Partials     3706    3712      +6
Flag Coverage Δ
#aggregator 82.3% <ø> (-0.1%) ⬇️
#cluster 85.7% <ø> (ø) ⬆️
#collector 63.7% <ø> (ø) ⬆️
#dbnode 79.9% <ø> (-0.1%) ⬇️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 73.9% <ø> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 17.6% <ø> (ø) ⬆️
#msg 74.9% <ø> (+0.1%) ⬆️
#query 67.1% <100%> (ø) ⬆️
#x 86.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7d870...126ead7. Read the comment docs.

Copy link
Collaborator

@benraskin92 benraskin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnikola arnikola merged commit b1b848e into master May 6, 2019
@robskillington robskillington deleted the arnikola/fix-binary branch May 6, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arithmetic binary operators between two vectors return empty result on m3's promql engine
2 participants