[index] Standardizes aggregate interfaces #1502
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1502 +/- ##
========================================
- Coverage 71% 70.9% -0.1%
========================================
Files 849 849
Lines 72250 72290 +40
========================================
+ Hits 51311 51318 +7
- Misses 17581 17616 +35
+ Partials 3358 3356 -2
Continue to review full report at Codecov.
|
| if err != nil { | ||
| return err | ||
| for _, doc := range batch { | ||
| if r.aggregateOpts.Type == AggregateTagNamesAndValues { |
There was a problem hiding this comment.
Maybe switch here and return if unknown?
src/dbnode/storage/index/types.go
Outdated
|
|
||
| // LimitExceeded returns whether a given size exceeds the limit | ||
| // the query options imposes, if it is enabled. | ||
| func (o AggregationOptions) LimitExceeded(size int) bool { |
There was a problem hiding this comment.
the embedding should give this to you fo free iirc
| @@ -186,6 +209,9 @@ type AggregateResultsOptions struct { | |||
|
|
|||
| // Optional param to filter aggregate values. | |||
| TermFilter AggregateTermFilter | |||
|
|
|||
| // Type determines what result is required. | |||
| Type AggregationType | |||
There was a problem hiding this comment.
can you delete AggregateResultsOptions now?
There was a problem hiding this comment.
I wanted to keep it as similar as possible to the regular Query path which does a similar thing when it breaks out the options relating to the result from those relating to the query parameters here
This PR fulfills several outstanding tasks for the aggregate endpoint:
This allows the query side PR(#1481) to be updated and landed, and minimizes required end-to-end work on #1483