[coordinator] only log stack traces on panic #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's often clear where errors are coming from. When stack traces are enabled, if a coordinator is being used as a prom backend and there's an error with the M3DB cluster then every single prom write causes a stack trace and the logs quickly fill up, making debugging difficult.
Codecov Report
@@ Coverage Diff @@
## master #1480 +/- ##
========================================
- Coverage 70.9% 70.8% -0.1%
========================================
Files 841 841
Lines 71909 71909
========================================
- Hits 50988 50962 -26
- Misses 17574 17595 +21
- Partials 3347 3352 +5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1480 +/- ##
========================================
- Coverage 70.9% 70.8% -0.1%
========================================
Files 841 841
Lines 71909 71909
========================================
- Hits 50988 50962 -26
- Misses 17574 17595 +21
- Partials 3347 3352 +5
Continue to review full report at Codecov.
|
arnikola
reviewed
Mar 20, 2019
schallert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's often clear where errors are coming from. When stack traces are
enabled, if a coordinator is being used as a prom backend and there's an
error with the M3DB cluster then every single prom write causes a stack
trace and the logs quickly fill up, making debugging difficult.