Add etcd operational guide #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardartoul
force-pushed
the
ra/etcd-docs
branch
from
8767d9e to
277be5a
Compare
benraskin92
reviewed
Feb 7, 2019
benraskin92
reviewed
Feb 7, 2019
schallert
reviewed
Feb 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #1354 +/- ##
========================================
- Coverage 70.7% 70.7% -0.1%
========================================
Files 822 822
Lines 70333 70333
========================================
- Hits 49778 49740 -38
- Misses 17320 17347 +27
- Partials 3235 3246 +11
Continue to review full report at Codecov.
|
schallert
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
LGTM. Can you link to this page anywhere we reference "external etcd"? I'm not sure if there's more references other than this page: https://github.com/m3db/m3/blob/b9497cb462f1475ee47009c8ea407ab0947ad65d/docs/operational_guide/placement_configuration.md#adding--removing-seed-nodes
|
@schallert good call, done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.