Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pooling options for index array pool to prevent (almost) unbounded growth over time #1254

Merged
merged 3 commits into from
Dec 19, 2018

Conversation

richardartoul
Copy link
Contributor

@richardartoul richardartoul commented Dec 18, 2018

screen shot 2018-12-18 at 3 01 36 pm

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #1254 into master will increase coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1254     +/-   ##
========================================
+ Coverage    70.6%   70.7%   +<.1%     
========================================
  Files         759     759             
  Lines       63828   63832      +4     
========================================
+ Hits        45121   45153     +32     
+ Misses      15781   15757     -24     
+ Partials     2926    2922      -4
Flag Coverage Δ
#aggregator 81.6% <ø> (ø) ⬆️
#cluster 85.6% <ø> (ø) ⬆️
#collector 78.4% <ø> (ø) ⬆️
#dbnode 80.8% <ø> (ø) ⬆️
#m3em 73.2% <ø> (ø) ⬆️
#m3ninx 75.4% <100%> (ø) ⬆️
#m3nsch 51.1% <ø> (ø) ⬆️
#metrics 18.2% <ø> (ø) ⬆️
#msg 74.9% <ø> (ø) ⬆️
#query 60.5% <ø> (ø) ⬆️
#x 76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a948b5a...8c77d44. Read the comment docs.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardartoul richardartoul merged commit cdfe6a2 into master Dec 19, 2018
@robskillington robskillington deleted the ra/fix-index-mem-leak branch December 19, 2018 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants